`dotcom-ui-layout` v0.3.1 -> v0.3.2 upgrade doesn't render drawer

Question

`dotcom-ui-layout` v0.3.1 -> v0.3.2 upgrade doesn't render drawer

Closed this issue 5 years ago · 8 comments

nickramsbottom commented 5 years ago

Upgrading from 0.3.1 -> 0.3.2 resulted in the drawer not rendering for Globetrotter.

We had not changed our implementation when upgrading.

Answer 1 · 2019-11-20T16:40:34.000Z

rollback PR in globetrotter: https://github.com/Financial-Times/globetrotter/pull/167

Answer 2 · 2019-11-20T16:48:48.000Z

I have spoken to Nick and the drawer menu was not present in the html for the simple header.

Answer 3 · 2019-11-21T10:58:58.000Z

v0.3.2 is in prod for all other apps using Page Kit which appear to be OK.

Could you link us to the integration of the Page Kit layout or header components @nickramsbottom so we can take a look?

Answer 4 · 2019-11-21T15:48:48.000Z

Sure! This is where we use it: https://github.com/Financial-Times/globetrotter/blob/master/packages/ssg/tools/make-edition-layouts.js

Answer 5 · 2019-11-22T08:18:57.000Z

Thanks - I don't see anything strange there, although I did spot this comment... is this statement still correct?

If it is then there is definitely something funky going on!

Answer 6 · 2019-11-22T08:32:10.000Z

OH, I know why...

The defaultProps will only be applied when using the createElement factory function... so calling the Shell() and Layout() functions directly will result in no default props.

So, either...

// Use the factory function
React.createElement(Layout, props)

// Or munge the default props yourself
Layout({ ...Layout.defaultProps, foo: 1, bar: 2 })

Answer 7 · 2019-11-25T08:28:57.000Z

Cheers @i-like-robots!! I'll have a go with this today

Answer 8 · 2019-11-25T08:54:20.000Z

All working, thank you!