[BUG] - Outer Shadow applies color correction
iammesutkaya opened this issue · 8 comments
Describe the bug
Applying an outer shadows, seems to apply some sort of color correction
To Reproduce
Steps to reproduce the behavior:
- Apply Shadow filter
- Choose Outer Shadow
Expected behavior
There shouldn't be any color correction
Screenshots
Environment
- OS/Version: Mac OS 14
- OBS Version: 29.1.3
- Composite Blur Plugin Version: 1.0
- Blur Algorithm/Type: Triangular & Dual Kawase
GPU
- GPU make/model Mac Mini M1
Additional context
Didn't have the bug with the previous version
Thank you for opening the issue @iammesutkaya. May I ask what type of source you're applying the filter to, so that I can replicate the issue? It looks like it might be a camera source embedded in a scene or group?
Yes, I initially noticed it on a camera source, but then tested it again on a color source. Same behaviour.
Thank you for this. I'll take a look at it this morning and try to figure out what is going on (it likely has to do with the conversion from sRGB color space to linear color space and back, which is necessary for proper mixing).
In the short term- a workaround would be to use the effect source (rather than the filter) and layer the shadow behind your webcam source. The effect source only uses your source as a mask, but doesn't attempt to mix any colors (and leaves the compositing/color mixing up to OBS). Something you might want to try as I work to fix this issue.
Yeah, that should work, thanks! Glad I could help!
I have confirmed the bug on Windows as well in the latest version of the code. Looking into it this morning.
Hi @iammesutkaya -
I found what was causing the issue and fixed it. I've merged in the changes, and will be generating a 1.0.1 release shortly. Please give the 1.0.1 release a try, and verify that it fixes the issue for you.
Ok, v1.0.1 with the fix is available at https://github.com/FiniteSingularity/obs-stroke-glow-shadow/releases/tag/v1.0.1
Yes, it's fixed! Thank you!