FlagBrew/PKSM

Bug Report - Exception occurs when moving box

Opened this issue · 1 comments

Badhaas commented

Describe the bug
Various crashes, exceptions and other weird behaviour occur when moving a box of Pokémon from an OR save file into an AS (or X or Y) save file. More details about repro and various cases below.

Variations:

  • Trying to move Pokémon leads to either a crash or part of the box getting ? blocks in their OT names

To Reproduce
Steps to reproduce the behaviour:

  1. Move a full box of Pokémon from Omega Ruby into PKSM storage (with the green indicator, selecting the entire box)
  2. Save, exit, restart with a different cartridge
  3. Load a save from a different game:
    • European cartridge, language set to Japanese
  4. Try to move the full box from PKSM storage into the game (with the green indicator, selecting the entire box)
  5. Notice PKSM crash (or if it doesn't, it changes
    • Or if it doesn't, notice weird ? boxes replacing characters in some Pokémon's OTs

Transfers in which this happened:

  • All cartridge saves, all set to english language except AS which is set to japanese language
  • happens regardless of using the cartridge save or checkpoint back-ups
  • OR > AS = crash/errors
  • OR > X or Y = crash/errors
  • OR > OR = no issue
  • Y > OR or AS = crash/errors
  • Y > X or Y = no issue

Expected behaviour
Pokémon can be moved and cloned without crashing or corrupting Pokémon data.

Screenshots

  • Exception occurred = happens in most scenarios
  • Blue touch screen = happens when pressing B on saving changes to storage
  • The ? box in the OT = happens to 2 Pokémon in this box (note, removing those 2 Pokémon and then moving the rest of the box still leads to the same crashes)

PXL_20240701_074107591
PXL_20240701_074422283
PXL_20240701_080401823

Information about your environment

  • OS version:
  • PKSM version: 10.1.1
  • Entrypoint: Luma CFW

Additional context
I've got a bunch of crash dumps, let me know if you need those as well.

PKSM Crash / error scenarios + when it doesn't happen:

  • Green indicator > Clone Box from storage > Move Into AS > arm11 crash
    • This often also happens when not cloning, and just moving the box from storage in the game. Yet that's not a 100% repro
  • Move entire box from storage to AS > Exit and don't save storage > PKSM Error screen
    • If moving with Green indicator
    • And also if moving with swap box button
  • Moving the individual pokémon:
    • Cloning with red indicator > leads to no issue
    • Cloning with green indicator > leads to ? in the OT name for some Pokémon
    • Moving leads to ? in the OT name
  • Moving the boxes without the Pokémon that get ? in their OT name still leads to the same crashes

EDIT:
Modified the repro as I noticed at happens for pretty much all boxes.
Left in the additional context notes, but this seems to be a much more common issue in general moving boxes with anything ORAS involved.

Badhaas commented

After further investigation, I've ruled out it's caused by corrupt Pokémon data.

To check whether it makes sense:

  • I created a new storage group and moved a box into it from OR
  • I checked, and it still causes the same crashes in AS and Y (so fair to assume in X as well)
  • Created a back-up of PKSM extdata with checkpoint
  • Moved the data to my PC
  • Used Pkhex-all-in-one to convert the bnk file into individual pk6 files
  • Opened PkHex with the AS safe file used earlier (the one that crashed)
  • Load box into the save file
  • Use PK Hex's validity check
  • All Pkm were valid
  • (although, they had 1 error of handling trainer not matching expected trainer name. Which makes sense since that's still the same as the first save file they were on, and it seems PKSM doesn't update this for any Pkm)

Since PkHex can load all Pkm, and "verify all Pkm" indicates there's no problems, I don't think this is caused by corrupt Pkm data.