Flank/flank

Flank action should fail if there are test failures

adamvduke opened this issue · 2 comments

adamvduke commented

According to @andreschab90, the flank action should fail if there are test failures. See #2332 for more details.

Quoting from #2332 (comment):

  • flank runs on ubuntu and all tests are passing -> step is marked as successful as expected
  • flank runs on ubuntu and tests are failing -> step is marked as successful, but failed was expected
  • flank runs on macOS and all tests are passing -> step is marked as successful
  • flank runs on macOS and all tests are failing -> step is marked as successful, but failed was expected

so the issue is that the step is always successful now, even so tests were failing. IMO the step should fail when tests are failing

andreschab90 commented

@adamvduke can be closed. works as expected. I had a config issue on my side. If a test fails, then step fails as well

adamvduke commented

Thanks for the update!