FlashpointProject/launcher

[BUG] Flashpoint Path not resolved in services.json <fpPath> variable substitution

Closed this issue · 1 comments

n0samu commented

Describe the bug
Some entries in services.json use the <fpPath> variable, but the launcher substitutes the variable for the literal flashpointPath value instead of the resolved path. This can cause service software to malfunction two reasons:

  • If the flashpointPath value ends with a slash, the path passed to the software can end up with two consecutive slashes.
  • If the flashpointPath value is relative, that same relative path value is passed to the software, which doesn't make sense because the flashpointPath value is supposed to be relative to the Launcher's folder.

To Reproduce
Steps to reproduce the behavior:

  1. Make sure the flashpointPath is set to ../ in the Launcher's config.json, as it is by default in Flashpoint.
  2. Make sure that services.json is passing a config path to the Apache service using the -f argument and <fpPath>.
  3. Switch the server to Apache Ultimate Webserver and restart the launcher.
  4. Look at the Logs and notice that the Apache server fails to start because an invalid config path was passed to it.

Expected behavior
The Apache server should start correctly when a config path is passed to it through services.json.

Desktop (please complete the following information):

  • OS: Windows 10
  • Flashpoint Version: 12.1
  • Log text: Server: (20024)The given path is misformatted or contained invalid characters: AH00532: Invalid config file path "..//Legacy/conf/httpd.conf"