FlorianWendelborn/bitwise

Extend Operation Functionality

Opened this issue · 4 comments

0xflotus commented

Can you please implement bit shift operations like logical shift, arithmetic shift and cyclic shift ?

  • Logical Shift (#45 — currently stuck)
  • Arithmetic Shift (#47 — currently stuck)
  • Cyclic Shift (#49)
FlorianWendelborn commented

Sorry, don’t have time for this right now, if you (or anyone else) want(s) to pick this up feel free to send a PR.

FlorianWendelborn commented

@0xflotus thanks for the PRs, I’m willing to get them merged soon. However, I left a couple questions on the individual pull requests

In general, this looks very mergeable already, pretty much only a few minor nitpicks open regarding public API.

0xflotus commented

Are all commits fine?

FlorianWendelborn commented

@0xflotus yes, I think so, I’m unfortunately just very busy right now. It’s still on my radar though 😞

  • 👍1