FlowingCode/AppLayoutAddon

Make AbstractFcAppRouterLayout.getTitle protected

javier-godoy opened this issue · 3 comments

Rename getCaption as getTitle in AbstractFcAppRouterLayout and make it protected instead of private static

private static String getCaption(HasElement content) {

Maybe it's better to call it "extractTitle" or "calculateTitle", because it's not just get it. Another thing is that it doesn't depend on the state of the object, is more like a utility method for extracting the title, isn't it better to remain static?

Maybe it's better to call it "extractTitle"
+1

Another thing is that it doesn't depend on the state of the object, is more like a utility method for extracting the title, isn't it better to remain static?

The suggestion of removing the static qualifier was in order to allow overriding the method

AbstractFcAppRouterLayout was removed in version 4.0.0 (#85)