Support for V23
vesanieminen opened this issue · 4 comments
Currently this addon does not work with V23. Do you have any plans to update this?
Hello. The addon is based on IronIcon (which is deprecated), andwe consider it's compatible with Vaadin 23 (https://addonsv23-staging.flowingcode.com/font-awesome-iron-iconset uses Vaadin 23.0.8). Maybe the application is missing some @Uses or whitelisting of the component. Can you share an example that reproduce the observed issue?
(We are also considering a migration from IronIcon to vaadin icon)
@javier-godoy here's the example application I tried this with earlier: https://github.com/vesanieminen/v23-fontawesome-test
I did add the @Uses annotations for both icons I'm using there but couldn't figure out how something should be whitelisted.
The app looks like this when I try to run it:
You need to add com.flowingcode to the whitelist in src/main/resources/application.properties (which, of course, is something we should have documented)
vaadin.whitelisted-packages = com.vaadin,org.vaadin,dev.hilla,com.example.application,com.flowingcode
Version 4.0.0 of this addon is compatible with Vaadin 23. Older versions should be compatible with Vaadin 14 up to 23.