fc-iconset is not compatible with 24.0.0.beta1

[javier-godoy]

Using version 4.2.0 of the add-on with Vaadin 24.0.0.beta1 fails with Uncaught (in promise) TypeError: this.__getIconId is not a function

FontAwesomeIronIconset/src/main/javascript/font-awesome-iron-iconset/fc-iconset.js

Line 30 in 5d54111

name = this.__getIconId(name);

[javier-godoy]

__getIconId was removed in vaadin/web-components#5334

[javier-godoy]

In vaadin 24 iconsets are registered without adding to DOM. This change requires a new major version of the add-on.

-import '@vaadin/icon/vaadin-iconset.js';
+import { Iconset } from '@vaadin/icon/vaadin-iconset.js';

template.innerHTML = `
-<vaadin-iconset name="lumo" size="1000">
<svg xmlns="http://www.w3.org/2000/svg">
<defs>...</defs>
</svg>
-</vaadin-iconset>
`;

-document.head.appendChild(template.content);
+Iconset.register('lumo', 1000, template);

[javier-godoy]

Will be released in 5.0.0