Google map addon is not working in V23.2
Closed this issue · 4 comments
When I'm trying to use this addon in a sample project in Vaadin 23.2 with Vite.
I have this error:
Failed to execute 'define' on 'CustomElementRegistry': the name "dom-module" has already been used with this registry
I didn't see a Vaadin 23 branch.
Here is an example: https://github.com/jcgueriaud1/googlemap-v23-issue
Hello, there's no Vaadin 23 branch, the latest release of the addon works okay in the latest release of Vaadin (23.1.X).
I was able to reproduce the reported issue, I will try to figure out what breaks the addon in Vaadin 23.2 when using Vite (it works okay if Vite is disabled).
FlowingCode/google-map#22 would partly fix this but then you would need to do the same fix for the dependency https://github.com/johnriv/google-apis (so probably fork it and fix it..)
Thanks @Artur- for the contribution and the hint, the web component is now updated with those fixes. @jcgueriaud1 we released a new version of the addon. Now it works okay in V23.2.
It's working perfectly, thanks a lot!