Fody/Costura

Support for IncludeRuntimeReferences in .NET Framework

0xced opened this issue · 1 comments

0xced commented

Summary

Starting with Costura 5, runtime references are skipped in .NET Framework. It was not the case in Costura 4.1.0. This is needed to properly embed Microsoft.Data.SqlClient.dll from the Microsoft.Data.SqlClient package when targeting .NET Framework. See also issue #651 which contains some technical details.

API Changes

I propose that instead of skipping runtime references altogether on .NET Framework, the IncludeRuntimeReferences configuration could default to false on .NET Framework and trueon .NET Core. That would allow the user of Costura to opt-in for embedding runtime references on .NET Framework.

Would you accept a pull request with those changes?

Intended Use Case

Microsoft.Data.SqlClient could be properly embedded by Costura when targeting .NET Framework this way without needing a horrible MSBuild trick. This would also benefit any other NuGet package that have a /runtimes directory with .NET Framework dlls.

Please test the latest beta.