When Nullguard.Fody is added to a project that is built as a NuGet package, the produced package has a dependency on NullGuard.Fody

Question

When Nullguard.Fody is added to a project that is built as a NuGet package, the produced package has a dependency on NullGuard.Fody

salfab opened this issue 6 years ago · 8 comments

Hi, I read the template, and I am not a patron, but as a good citizen, I just wanted to raise awareness regarding an issue you may have never come accross before. Even if this issue gets ignored by NullGuard.Fody's developers, it may help other people that use the package and want to work around the problem manually.

Describe the issue

When Nullguard.Fody is added to a project that is built as a NuGet package, the produced package has a dependency on NullGuard.Fody

Minimal Repro

create a new .net library, make sure "Generate nuget package on build" is checked in the project's properties, and build solution.

Check the produced .nupkg : NullGuard.Fody is listed as a dependency to the produced package.

Submit a PR that fixes the bug

No PR, but the idea is to apply this tag in the .csproj in the consuming project, upon installation of NullGuard.Fody.

If the feature never gets implemented, this can be applied manually by whoever references the NullGuard.Fody package in their own NuGet package project.

In the consuming project, replace

    <PackageReference Include="NullGuard.Fody" Version="1.8.5" />

with

    <PackageReference Include="NullGuard.Fody" Version="1.8.5" >
      <PrivateAssets>all</PrivateAssets>
    </PackageReference>

For more info on the PrivateAssets tag, see the controlling dependency assets article on microsoft's documentation

Answer 1 · 2019-01-29T13:00:37.000Z

@salfab can u send a doco PR to this file that adds the above https://github.com/Fody/Home/blob/master/pages/source/usage.md

Answer 2 · 2019-01-30T07:44:33.000Z

Of course.

Should there also be a mention of it in the doco of NullGuard, or only in Fody/Home ?

Answer 3 · 2019-01-30T08:05:30.000Z

Done. I opened a PR on the usage.md file.

Answer 4 · 2019-01-30T08:31:59.000Z

only in Fody/Home. i dont think it is valuable enough to replicate over 50+ addin repositories, since we are essentially documenting standard nuget behavior

Answer 5 · 2019-01-30T09:51:56.000Z

makes sense !

…

On Wed, Jan 30, 2019 at 9:32 AM Simon Cropp ***@***.***> wrote: only in Fody/Home. i dont think it is valuable enough to replicate over 50+ addin repositories, since we are essentially documenting standard nuget behavior — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#124 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AApm5AKEDWQf-dCsPnqIGPknB6zdO-nKks5vIViAgaJpZM4aX-BE> .

Answer 6 · 2019-01-30T09:57:07.000Z

so re this

and I am not a patron,

do you feel $3 a month is too much ?

Answer 7 · 2019-01-30T10:09:13.000Z

I'm not saying it is, I just literally discovered Fody accepted donations while writing my issue.

Answer 8 · 2019-02-02T02:04:56.000Z

given the doco is added (thanks for the PR) i will close this