FoilPHP/Foil

Nested Blocks Fail

brad-jones opened this issue · 4 comments

brad-jones commented

Hi @Giuseppe-Mazzapica ,

I have another test case for you:
https://gist.github.com/brad-jones/62985a9511836d0521b9

Thought I would try to use Foil as a code generation tool. Works really well but then I wanted to tidy up the horrible formatting and created the "indent" block, which works great but only one level deep.

git clone, composer install, then run these:

  • php fails.php
  • php success-not-nested.php
gmazzap commented

Hi @brad-jones

Thanks for reporting this issue. I testes very simple nested blocks and they worked, but I see your example failing. Considering there is a bit of logic involved there I'm not sure which is the failing part.

I'll update here as soon as I find the problem.

Thanks.

gmazzap commented

@brad-jones Yes, it was a bug on the way block args were handled.

Should be fixed in dev-dev.

Can you give it a try?

brad-jones commented

Hi @Giuseppe-Mazzapica,

Yep I can confirm the changes have fixed the bug.

Cheers Brad.

gmazzap commented

Hi @brad-jones thanks for your feedback. Going to merge and release 0.6.5 with fix.