Reboot classes included in both themes
prymitive opened this issue · 1 comments
When using bootstrap-dark reboot styles are included under .bootstrap {} (see https://github.com/ForEvolve/bootstrap-dark/blob/master/scss/toggle-bootstrap.scss#L20), the side effect is that they might be more specific then extra classes imported and so override them. An example is using FontAwesome icons that use .fa-xxx on svg elements for extra styling, those styles are overwritten by https://github.com/twbs/bootstrap/blob/v4.6.0/scss/_reboot.scss#L257-L262.
Would it be possible to move reboot from under .bootstrap {}?
It would be possible but will require some additional efforts to ensure both light and dark stylesheets are not creating conflicts as _reboot.scss is included in both. Moreover, at first glance, there seem to be some color variables involved in _reboot.scss, which may cause some conflicts. One example would be L52 and L54, and there are more.
That said, this could be fixed as part of some optimization related to #20 or #39, but my bandwidth is limited. I'll keep this in mind and hopefully find some time to move those items forward, including this one.