ForEvolve/git-extensions-for-vs-code

Also work with keyboard nav

TaoK opened this issue · 6 comments

TaoK commented

In VSCode most commands can be invoked with autocomplete at the Ctrl-Shift-P prompt.

When you select "Browse with Git Extensions" here, however, you get an error:

Command 'Browse with Git Extensions' resulted in an error (Cannot read property 'fsPath' of undefined)

Carl-Hugo commented

That error makes sense since the extension opens Git Extensions based on the current file or folder that you right-click. TBH, I never thought of that one.

That said, how would you have the command to work (both in a folder and in a workspace)?

TaoK commented

I would assume the most sensible thing would be to have the command look at the active window, to figure out the path of the file open there...? (When not invoked with a target file / folder)

Carl-Hugo commented

How about the following?

  • For a folder: open the folder's git repo
  • For a workspace: have the user choose what folder's git repo to open

EDIT:

  • I forgot "orphan files": if the last file that has the focus was an "orphan", run the command against that file.
Carl-Hugo commented

Is this something that you or others would use? If yes, what's your use-case?

I don't mind looking into this when I have the chance, but only if it is useful, not as a missing feature that no one will ever use or care.

  • 👍1
akshaykiran commented

I feel its useful to have it open the repository of the current file. I typically use ctrl+shift+p all the time. I believe I'm not the only one

Carl-Hugo commented

I feel its useful to have it open the repository of the current file. I typically use ctrl+shift+p all the time. I believe I'm not the only one

I use ctrl+shit+p all the time as well, but would you use it to "Browser with GitExt"?