Consider implementing `IComparable` in the path types

Question

Consider implementing `IComparable` in the path types

Opened this issue 8 months ago · 4 comments

This has hit me several times already: absence of IComparable<T> doesn't allow to use the type as a key in F#'s Map.

Let's define the comparability somehow.

Answer 1 · 2024-08-26T07:52:51.000Z

Hi. I would to implement this feature.
Will we be OS dependent or will we always compare case-sensitive?

Answer 2 · 2024-08-26T10:11:04.000Z

Let's implement it as string comparison for now. A PR with more comparers is cooking: #84

My view is that we should use the PlatformDefaultPathComparer for default comparison (fast and IO-free, while providing good quality for most cases), and the user is free to use any other in case they want.

Answer 3 · 2024-09-01T10:25:38.000Z

I kinda don't want to add using System.Runtime.InteropServices to Absolute and Local paths to make comparing platform dependent
Looks like #84 is almost done, so I'd prefer to finish it and then add IComparable<>

Should I fork #84 to finish it?

Answer 4 · 2024-09-01T11:51:50.000Z

Sure, you can fork and finish it. Just make sure to preserve the original contributor's commit, to preserve their authorship for the history and proper acknowledgment.