ForbesLindesay/passport-raven

All WLS response parameters are taken to be nonoptional

Closed this issue · 0 comments

When a WLS response is received, the number of received parameters is checked against the total number of response parameters (https://github.com/ForbesLindesay/passport-raven/blob/master/index.js#L137). However, according to the WAA->WLS communication protocol (https://raven.cam.ac.uk/project/waa2wls-protocol.txt), a number of the response parameters are optional. This means that an error is raised for some responses that are actually valid (for example, cancelling a Raven login).