FormidableLabs/nuka-carousel

Attributes do not match their roles on carousel dots

LinnJS opened this issue · 1 comments

Bugs and Questions

Prerequisites

  • I've searched open issues to make sure I'm not opening a duplicate issue
  • I have read through the docs before asking a question
  • I am using the latest version of nuka-carousel

Describe Your Environment

  • What version of nuka-carousel are you using?
    "nuka-carousel": "^5.5.1",
  • What version of React are you using?
    "react": "18.2.0",
  • What browser are you using?
    Brave Browser v1.49.120

Describe the Problem

We are using the default nuka-carousel carousel dots and styling them by overwriting styles in a css file. When running a lighthouse audit our accessibility score dropped from a 100 to a 90 when implementing a carousel with dots. On our 100 previous score we had a nuka-carousel but used custom prev next buttons with no issues. Adding another nuka-carousel with dots dropped the score and caused an accessibility error.

Error:
Each ARIA role supports a specific subset of aria-* attributes. Mismatching these invalidates the aria-* attributes. Learn more.

image

Expected behavior:

Aria tags should match roles of element

Actual behavior

Aria error of ARIA role supports a specific subset of aria-* attributes. Mismatching these invalidates the aria-* attributes. Learn more.

Feel free to go to website and run lighthouse with accessibility audit checked.

Website link

https://bunkr-p9eavz7e8-linnjs.vercel.app/

LinnJS commented

This looks to have been fixed thank you @clarkgunn