FormidableLabs/serverless-jetpack

Feature/Bug/Research: Handle collapsed files in zip bundling.

ryan-roemer opened this issue · 1 comments

If we have ../node_modules/foo and node_modules/foo in files in a package, they get collapsed in the zip file as node_modules/foo. Multiple entries with zipinfo but only a single file when expanded on disk.

Task:

  • Research the situation to better understand what's going on.
  • Add option or something to flag detected collapsed files.

Remedies:

  • Potentially error out if detected. E.g., custom.jetpack.collapsed.bail = true
  • Potentially (long shot) heuristically "fix" the problem.
  • Option for "winners" if multiple detected. E.g.
    custom:
      jetpack:
        collapsed:
          resolutions:
            # <GROUP>: <WINNER PATH>
            node_modules/lodash: ../node_modules/lodash
    

Added detection and jetpack.collapsed.bail option in serverless-jetpack@0.10.2