FormingWorlds/JANUS

Mixing ratios don't always add up to 1

Closed this issue · 3 comments

MFTondreau commented

In the case where all chemical species condense at the top of the atmosphere (when the dry_list is empty), the mixing ratios don't add up to 1 anymore.

timlichtenberg commented

Is this a general or an edge case? Did the last PR of @nichollsh resolve this? As far as I understand this makes sure that not all species can condense anymore.

nichollsh commented

I think it's more of an edge case. Last I heard from @MFTondreau is that this is a result of the assumption that the atmosphere has to diabatically cool throughout the whole column, which at some level will force all volatiles to condense, and therefore drop the total VMR below unity.

timlichtenberg commented

Ok, this then seems more of a new feature development than a bug, there are of course limits to the adiabatic assumption inherent to JANUS. Please suggest to @MFTondreau to make use of / contribute to JANUS instead of a offline detached version that is probably out of date. :)