FragLand/minestat

Reorder SLP protocol attempts

ldilley opened this issue · 2 comments

Expected Behavior

  • Anticipated data should be returned by a running Minecraft server.

Actual Behavior/Symptoms

  • The remote TCP port of the Minecraft server refuses communication for a duration of approximately 4 seconds under certain conditions.

How to Reproduce Behavior/Symptoms

  • Attempt to request data from Minecraft 1.4 servers using SLP protocol v1.7 or Minecraft 1.3 servers using SLP protocol v1.6. The Minecraft server seems to block subsequent TCP connection attempts for approximately 4 seconds. This behavior was reported by @mindsolve.

MineStat Version

  • Latest

Programming Language and Compiler/Interpreter Version

  • All language implementations that support multiple SLP protocol versions

Operating System

  • Any

The new proposed order of SLP request attempts should be as follows:

  1. 1.4/1.5 (legacy)
  2. 1.8b/1.3 (beta)
  3. 1.6 (extended legacy)
  4. 1.7 (JSON response)

Resolved in PRs #69 and #71.