FragLand/terracord

NullRef in OnLeave

Closed this issue · 3 comments

moisterrific commented

Not sure why it happened, couldn't reproduce it later myself.

image

ldilley commented

Are you sure this is 23d806a? For starters, that exception was changed to read Exception caught after player joined or left TShock server: {nre.Message}. Furthermore, the relevant line has been commented. See line 207 of https://github.com/FragLand/terracord/blob/master/Terracord/Terracord.cs for details. Lastly, there is a null check for eventArgs in the current commit which should prevent the NullReferenceException from being caught.

moisterrific commented

Oops I think mine is outdated, I will updated it and re-check.

moisterrific commented

yup it's fixed, my mistake forgetting to update to the latest commit.