FrameworkComputer/inputmodule-rs

ledmatrix does not compile

sonologic opened this issue · 3 comments

Doing cargo make --cwd ledmatrix results in:

[cargo-make] INFO - Calling cargo metadata to extract project info
[cargo-make] INFO - Cargo metadata done
[cargo-make] INFO - Project: ledmatrix
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: default
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Execute Command: "cargo" "fmt"
[cargo-make] INFO - Skipping Task: format-toml-conditioned-flow 
[cargo-make] INFO - Execute Command: "cargo" "build" "--target" "thumbv6m-none-eabi" "--features" ""
   Compiling serde v1.0.210
   Compiling thiserror v1.0.63
   Compiling cortex-m-rt v0.7.3
   Compiling num_enum v0.5.11
   Compiling defmt-parser v0.3.4
   Compiling pio v0.2.1
   Compiling rp2040-pac v0.4.0
   Compiling rp2040-hal-macros v0.1.0
   Compiling defmt-macros v0.3.9
   Compiling defmt v0.3.8
   Compiling ssmarshal v1.0.0
   Compiling usbd-hid-macros v0.6.0
error[E0277]: the trait bound `usbd_hid_descriptors::MainItemKind: From<std::string::String>` is not satisfied
   --> /home/gmc/.cargo/registry/src/index.crates.io-6f17d22bba15001f/usbd-hid-macros-0.6.0/src/spec.rs:512:43
    |
512 |             self.set_item(name, item_kind.into(), settings, bits, quirks);
    |                                           ^^^^ the trait `From<std::string::String>` is not implemented for `usbd_hid_descriptors::MainItemKind`
    |
    = help: the trait `From<&str>` is implemented for `usbd_hid_descriptors::MainItemKind`
    = note: required for `std::string::String` to implement `Into<usbd_hid_descriptors::MainItemKind>`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `usbd-hid-macros` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
Error while executing command, exit code: 101

Seems like this is this issue: twitchyliquid64/usbd-hid#72

you can probably fix it by running "cargo update usbd-hid" in the top-level folder, though this may cause other issues if updating that causes other updates

Generally though, the bumo should be 0.6.1 to 0.6.2 wich just fixes usbd-hid specifying its own dependencies badly.

@laundmo indeed, I bumped it to 0.8.2 (the latest), and now it compiles. Haven't actually tried the firmware yet with this bumped version.

And it seems to run as well.