Changed jap_utils functions to call by reference for better error handling - [merged]
Closed this issue · 24 comments
In GitLab by @fraunhofer-iis-anon on Mar 20, 2020, 14:54
Merges issue_20 -> dev
- adjusted tests
- adjusted japi.c
- adjusted demo.c
In GitLab by @fraunhofer-iis-anon on Mar 20, 2020, 14:56
added 3 commits
- 39aeb0fb...cd38f2c5 - 2 commits from branch
dev - fa69490b - Changed jap_utils functions to call by reference for better error handling
In GitLab by @cstender on Mar 23, 2020, 16:22
Commented on include/japi_utils.h line 34
Aus Interesse: Warum sval und nicht nur val?
Bei der Beschreibung bitte aufpassen: da steht ganz oft "key value". Key und Value sind aber zwei verschiedene Sachen und wir sollten den Namen "key value" vermeiden, wenn es nur um den Key geht.
zum Beispiel so:
\param key Corresponding key to the requested value
\param val Requested value
In GitLab by @cstender on Mar 23, 2020, 16:23
Commented on include/japi_utils.h line 39
bei -2 und -3 siehe oben (nur key und nicht key value)
In GitLab by @cstender on Mar 23, 2020, 16:25
Commented on src/japi_utils.c line 28
if a legal string value...
In GitLab by @cstender on Mar 23, 2020, 16:26
Commented on src/japi_utils.c line 51
is not a string type
In GitLab by @cstender on Mar 23, 2020, 16:33
Commented on test/japi_test.cc line 26
Den Test GetValueAsStringAndBool könntest du noch erweitern und schauen, ob auch die Fehler korrekt zurückgegeben werden.
In GitLab by @cstender on Mar 23, 2020, 16:34
Schaut gut aus! Bitte noch die Kommentare/Dokumentation anpassen und den Test erweitern.
In GitLab by @fraunhofer-iis-anon on Mar 24, 2020, 13:16
Commented on include/japi_utils.h line 34
changed this line in version 3 of the diff
In GitLab by @fraunhofer-iis-anon on Mar 24, 2020, 13:16
Commented on include/japi_utils.h line 39
changed this line in version 3 of the diff
In GitLab by @fraunhofer-iis-anon on Mar 24, 2020, 13:16
Commented on src/japi_utils.c line 28
changed this line in version 3 of the diff
In GitLab by @fraunhofer-iis-anon on Mar 24, 2020, 13:16
Commented on src/japi_utils.c line 51
changed this line in version 3 of the diff
In GitLab by @fraunhofer-iis-anon on Mar 24, 2020, 13:16
added 1 commit
- d3953147 - adjusted comments
In GitLab by @fraunhofer-iis-anon on Mar 24, 2020, 13:46
added 1 commit
- 4888ee53 - extended unit test to the new return values
In GitLab by @fraunhofer-iis-anon on Mar 24, 2020, 14:14
added 1 commit
- 8dddd459 - fixed typo and adjusted comments
In GitLab by @fraunhofer-iis-anon on Mar 24, 2020, 14:19
Commented on include/japi_utils.h line 34
val macht mehr Sinn, weil generischer. Habe es entsprechend angepasst.
In GitLab by @cstender on Mar 24, 2020, 18:03
Commented on test/japi_test.cc line 26
changed this line in version 6 of the diff
In GitLab by @cstender on Mar 24, 2020, 18:03
added 2 commits
- 21563caf - Extended helper functions for int, int64 and double
- 566b31da - Merge branch 'issue_31' into 'issue_20'
In GitLab by @cstender on Mar 24, 2020, 18:33
Commented on include/japi_utils.h line 38
changed this line in version 7 of the diff
In GitLab by @cstender on Mar 24, 2020, 18:33
added 1 commit
- e662a001 - fixed typo in parameter description
In GitLab by @cstender on Mar 24, 2020, 18:34
enabled an automatic merge when the pipeline for e662a0015e00cd62c235ef9ffad2343fc2d10bfb succeeds
In GitLab by @cstender on Mar 24, 2020, 18:34
resolved all threads
In GitLab by @cstender on Mar 24, 2020, 18:37
merged