cmake: remove redundant compiler and linker flags - [merged]
Closed this issue · 12 comments
In GitLab by @fraunhofer-iis-anon on Apr 21, 2020, 14:58
Merges fix_cmake -> dev
In GitLab by @cstender on Apr 21, 2020, 16:08
Commented on CMakeLists.txt line 12
nachdem die Flags nichts mit dem Release zu tun haben, schau mal, ob man die nicht besser über target_compile_options setzt, siehe auch:
https://cmake.org/cmake/help/v3.11/command/target_compile_options.html
https://www.brianlheim.com/2018/04/09/cmake-cheat-sheet.html
In GitLab by @fraunhofer-iis-anon on Apr 22, 2020, 13:21
Commented on CMakeLists.txt line 12
changed this line in version 2 of the diff
In GitLab by @fraunhofer-iis-anon on Apr 22, 2020, 13:21
added 1 commit
- 15641cec - add compile flags with target_compile_options()
In GitLab by @cstender on Apr 22, 2020, 17:42
Commented on CMakeLists.txt line 70
ich glaube die Präprozessor-Flags gehören hier nicht rein, weil sie nur den C Code betreffen? Bitte auch prüfen, ob es -phtread hier braucht.
In GitLab by @cstender on Apr 22, 2020, 17:43
Commented on CMakeLists.txt line 24
Nachdem es weder "Multicore" noch "Präprozessor-Flags" sind würde ich sie hier einfach auflisten.
In GitLab by @fraunhofer-iis-anon on Apr 23, 2020, 08:53
Commented on CMakeLists.txt line 70
changed this line in version 3 of the diff
In GitLab by @fraunhofer-iis-anon on Apr 23, 2020, 08:53
Commented on CMakeLists.txt line 24
changed this line in version 3 of the diff
In GitLab by @fraunhofer-iis-anon on Apr 23, 2020, 08:53
added 1 commit
- 8b5349df - list compiler flags directly
In GitLab by @cstender on Apr 23, 2020, 09:38
resolved all threads
In GitLab by @fraunhofer-iis-anon on Apr 23, 2020, 11:41
added 1 commit
- 61883e9f - use best practice for build type
In GitLab by @cstender on Apr 23, 2020, 13:38
merged