Add more debug messages

[tyalie]

When trying to use this extension with flatpak there are a few pitfalls that one needs to handle. Sadly it is almost impossible to get information from this extension what exactly is happening right now or where any kind of errors are to be found. Is it possible to get more debug logs of what is happening under the hood? i.e. stdout / stderr by the messaging host.

[Frederick888]

What kinds of pitfalls you bumped into in your flatpak setup?

If it's about the initial native messaging / manifest setup, error info I can get from Thunderbird is quite limited in the first place. In my experience, except for 'no such native application' which often means TB cannot locate the manifest file, it's usually just a generic 'unexpected error'.

If it happened after the initial setup (so that TB can already invoke the messaging host), I can potentially add more logs, but it really depends on what you wanted.

I'd appreciate it if you can contribute a post to Discussions regarding flatpak btw :)

[tyalie]

Hi. In this case the external-editor-revived replied with smth along the lines of field "configuration" missing on line 1 column 22. As it turns out this was a result of having an older version of the binary running than what the extension expected, but I was only able to find this, by modifying the external_editor_revived.json to open a bash script with the following content

flatpak-spawn --host ./external-editor-revived "$@" 2>&1 | tee /tmp/out

Getting a dump of the stdout and stderr without needing to bend them and printing it into the Error Console would be lovely.

I'd appreciate it if you can contribute a post to Discussions regarding flatpak btw :)

I'm not sure if this is specific to flatpak right now, but maybe to helps to talk there about how I got it running.

EDIT: I've added a discussion post talking about my config

[Frederick888]

Thanks for the Discussions post!

field "configuration" missing on line 1 column 22

That's quite strange considering this attribute's been there since the very first release [1]. The thing is, Thunderbird actually talks to the messaging host via stdio. Stderr from the host is captured in TB's Error Console, but it must be done with great caution if you ever want to intercept std in/out. Since it appears that a shell wrapper was needed in your flatpak setup, are you sure you didn't alter std in/out in any way? By the way the communication is not purely in JSON, there is a small preamble (size of messages) involved [2]. [1] https://github.com/Frederick888/external-editor-revived/blob/a70cec9007ac8fc3c99a818ee2505416a1764504/src/model/messaging.rs#L29 [2] https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Native_messaging#app_side

[tyalie]

8 Mar 2023 08:58:12 Frederick Zhang ***@***.***>:

Thanks for the Discussions post! > field "configuration" missing on line 1 column 22 That's quite strange considering this attribute's been there since the very first release [1]. The thing is, Thunderbird actually talks to the messaging host via stdio. Stderr from the host is captured in TB's Error Console, but it must be done with great caution if you ever want to intercept std in/out. Since it appears that a shell wrapper was needed in your flatpak setup, are you sure you didn't alter std in/out in anyway? By the way the communication is not purely in JSON, there is a small preamble (size of messages) involved [2]. [1] https://github.com/Frederick888/external-editor-revived/blob/a70cec9007ac8fc3c99a818ee2505416a1764504/src/model/messaging.rs#L29 [2] https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Native_messaging#app_side On 8/3/23 00:41, Sophie Tyalie wrote: > Hi. In this case the external-editor-revived replied with smth along the lines of |field "configuration" missing on line 1 column 22|. As it turns out this was a result of having an older version of the binary running than what the extension expected, but I was only able to find this, by modifying the |external_editor_revived.json| to open a bash scrip with the following content > > flatpak-spawn --host ./external-editor-revived"$@" 2>&1 | tee /tmp/out" > > Getting a dump of the stdout and stderr without needing to bend them and printing it into the |Error Console| would be lovely. > > I'd appreciate it if you can contribute a post to Discussions <https://github.com/Frederick888/external-editor-revived/discussions> regarding flatpak btw :) > > I'm not sure if this is specific to flatpak right now, but maybe to helps to talk there about how I got it running. > > — > Reply to this email directly, view it on GitHub <#102 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCMP73IQWIEDP7APY5FEFLW243KNANCNFSM6AAAAAAVSNRZME>. > You are receiving this because you commented.Message ID: ***@***.***> > -- Frederick Zhang PGP: 8BFB EA5B 4C44 BFAC C8EC 5F93 1F92 8BE6 0D8B C11D — Reply to this email directly, view it on GitHub[#102 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ADNS35HCIBFTU2LUD2CTW5DW3A3Y5ANCNFSM6AAAAAAVSNRZME]. You are receiving this because you authored the thread.[Tracking image][https://github.com/notifications/beacon/ADNS35CSA6RRBA5ISZQ6CS3W3A3Y5A5CNFSM6AAAAAAVSNRZMGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSXAEF2I.gif]

Hmh interesting. Updating the binary definitely fixed it immediately thoo. Not sure what happened there. Yeah maybe I should read up on how bash scripts change the stdin/err, but it seems to not be to much of a hurdle as it runs fine rn

[Frederick888]

That's alright. I'll close the ticket then. Please just file another one when you have more details.