[Bug]: Cannot change playback speed to 1 if default is 1.25
Opened this issue · 9 comments
Guidelines
- I have encountered this bug in the latest release of FreeTube.
- I have encountered this bug in the official downloads of FreeTube.
- I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
- I have searched the documentation for information that matches the description of the bug I want to file, without success.
- This issue contains only one bug.
Describe the bug
I set the default playback speed to 1.25. While watching a video playing at my default speed (1.25), I decided I wanted to slow it down to normal speed so I went to change the speed while the video was playing but it would not let me select 1. It lets you select all other playback speeds except for 1. This works fine in the official v0.22.0 Beta release but not in the current (and recent) nightly builds, which I grabbed to fix the issue of the audio track defaulting to German on some videos.
Expected Behavior
It your default playback speed is set to 1.25, the player should allow you to select 1 for a playback speed while the video is playing.
Issue Labels
feature stopped working
FreeTube Version
v0.22.0-nightly-5301 Beta
Operating System Version
Windows 11 24H2
Installation Method
Portable
Primary API used
Local API
Last Known Working FreeTube Version (If Any)
v0.22.0 Beta
Additional Information
No response
Nightly Build
- I have encountered this bug in the latest nightly build.
I can replicate this as well. I don't see any recently changed code in FreeTube that's touched this, so I suspect this may be an upstream issue like #6281.
What's odd is that it lets you change the speed to everything else except 1 and, also, that it works correctly in the current "Release" build; it seems to only be an issue with the nightly ones...
In our logic, we supply the playbackRates used by the player, and excluding the mouse scroll playback rate change feature, we only invoke our changePlayBackRate function through keyboard activation, which still works correctly in being able to set it to 1 through the p/o keys. So I'd predict it's some bug that occurs when the defaultPlaybackRate supplied to Shaka is != 1.
@kommunarr im unable to test myself so could you verify this on https://nightly-dot-shaka-player-demo.appspot.com/
@efb4f5ff-1298-471a-8973-3d47447115dc Not sure how to test with a defaultPlaybackRate other than 1 in the demo.
Ah my bad. Maybe the change could be related to this weird upstream bug #6281
The root cause it the same for all 3 problems, shaka-player changed the way that the UI sets the playback rate with 4.12.x (FreeTube 0.22.0 uses 4.11.10 as 0.12.x was released later). They have fixed the resetting of the playback rate on the main branch/nightly demo but the video still starts playing when you select a playback rate and this issue happens on the nightly demo too. When the page loads run document.querySelector('video').defaultPlaybackRate = 1.5; document.querySelector('video').playbackRate = 1.5 in the dev tools and then select one of their test assets.
96bcdc3 fixed the speed being reset on play/pause, but I still can't switch to x1 playback speed by clicking if I have x2 by default.
That is entirely expected, because as explained in my comment right above yours, they have only fixed 1/3 issues so far.