[Request] Add Bromite System Webview to NoGoolag Edition
Closed this issue · 14 comments
It would be nice to have Bromite System Webview replace the preinstalled webview. The install instruction for the webview is very unintuituve so it will be helpful if there's a script for it.
The preinstalled one on the ROM that I am using is different than the one on the Play Store, so only the ROM maintainer can update it and thus it is few versions behind than Chromium. Bromite Webview will make it easy to update it on deGoogled phones and will also include the privacy features of Bromite.
I haven't replied to this issue because at the time I wasn't sure (and also somewhat busy). I was willing to try, but looking around it seemed getting bromite webview to work these days seems to be a complicated process.
accidentally pressed close instead of comment 🤦
Meanwhile, a friend has been working on updating the nanodroid bromite package to work with the newer bromite versions if you want to try:
https://gitlab.com/zer0def/NanoDroid/-/packages
They're mostly doing it for personal use, so they might not work on issues that don't affect them personally. E.g. apparently safetynet doesn't work with it for complicated reasons.
Thanks, but it is not installing on my device. Says that it cannot mount /system_root.
@eredrolo Sorry about that, I made a hard-to-spot mistake when ripping out Google-related components in NanoDroid and those builds are based on my personal preference branch, not Bromite-related feature one, invariably surfacing the issue. Should be fine with today's build.
@zer0def Thanks, the new build works. But I can't choose Bromite as the webview implementation. Looks like I'll have to edit framework-res.apk as stated in the Bromite wiki. I don't have much experience with this and it seems that it can cause bootloops if I do it incorrectly, so I think I'll just use the default webview for now.
@eredrolo That's what it's supposed to be doing and has worked for me so far. If it doesn't work, look for BromiteOverlay.apk across overlay dirs, like find / -iname bromiteoverlay.apk. It should contain your previous allowed webview list with Bromite's entry appended at the end (you can pull down the .apk and unzip it to confirm).
@zer0def I don't see any bromiteoverlay.apk file and the webview xml file hasn't changed. Nanodroid logs show that it's installing BromiteOverlay.apk and doesn't give any error.
That means the installation is quietly failing for unknown reasons - is Bromite WebView installed at all and is it installed as a system app?
@zer0def Yes, Bromite Webview is installed as a system app. I can see it in the apps list and in /system/app/
Without the overlay containing the override adding it the allowed list, it obviously isn't going to work. Would you be able to provide NanoDroid logs from the installation (either into system, or as a Magisk module)?
@zer0def It works now. I had to manually mount /system, /system_ext and /vendor in TWRP and now it installed correctly. Thanks for the help and for the installer.
Just double-checked with a fresh flash and it might be that the recovery in use is misbehaving in strange ways (likely just expects mounting by twrp mount <partname>, instead of relying on fstab). Can't do anything about it without narrowing down the script's scope to be running only on TWRP, which makes no sense of doing.
Glad you managed to get it to work, tho.
Whoops, bromite is unmaintained now.