Use cakephp 3 phpcs template?

Question

kevinquinnyo opened this issue 10 years ago · 3 comments

I notice the code in the cake3 branch does not conform to the cakephp 3 phpcs standards. (docblocks and tab/spacing mostly) Shouldn't it?

Is there any reason it doesn't? If I want to make a PR for something, should I conform to the current style? Or use the cakephp 3 standards?

If this is just something on the to-do list, let me know. I don't mind helping to make the 'cake3' branch conform to the cakephp 3 phpcs template.

Answer 1 · 2015-05-26T04:30:24.000Z

A PR to update code to new coding standard is welcome.

Answer 2 · 2015-05-26T16:05:05.000Z

build failed because travis CI is using a different phpcs template I believe

Answer 3 · 2015-05-27T03:33:07.000Z

Closing as PR is opened.