FriendsOfGalaxy/galaxy-integration-uplay

Plugin detecting game I don't own (surplus game that appears only in Uplay Club)

Opened this issue · 4 comments

The plugin is detecting that I own For Honor (and have played it for about an hour), and it appears in GOG Galaxy, but I don't have it in my Uplay library. I thought I might have claimed it during a free giveaway, but when I spoke to Uplay support they said that it wasn't activated on my account, but that it shows I took part in the open beta, so I think this could be what the plugin is detecting. Is there any way not to detect this? Because this isn't something I can actually access/install anymore.

This is what the owned games section of the Uplay log looks like:

{"owned_games": [{"game_id": "c8b3f1c6-a246-4ffe-a837-a49d6bb0ce52", "game_title": "Assassin\u2019s Creed\u00ae IV Black Flag\u2122", "dlcs": [], "license_info": {"license_type": "SinglePurchase"}}, {"game_id": "581", "game_title": "Fallout\u00ae 3 Game of the Year Edition", "dlcs": [], "license_info": {"license_type": "SinglePurchase"}}, {"game_id": "600a36b8-ed3e-40c6-8a5f-c2b890eda50a", "game_title": "NAME", "dlcs": [], "license_info": {"license_type": "SinglePurchase"}}, {"game_id": "b0d49994-ec9a-4809-908a-b5970791b0f7", "game_title": "Discovery Tour by Assassin's Creed: Ancient Egypt", "dlcs": [], "license_info": {"license_type": "SinglePurchase"}}, {"game_id": "215c8900-909e-4dc4-8fa8-025785125435", "game_title": "Discovery Tour Ancient Greece by Ubisoft", "dlcs": [], "license_info": {"license_type": "SinglePurchase"}}, {"game_id": "882ad5b5-f549-44a1-a434-c465d22fe4bf", "game_title": "For Honor", "dlcs": [], "license_info": {"license_type": "SinglePurchase"}}]}}

Here is the log file:
plugin-uplay-afb5a69c-b2ee-4d58-b916-f4cd75d4999a.log

A secondary issue is that neither Discovery Tour games ("Discovery Tour by Assassin's Creed: Ancient Egypt" & "Discovery Tour Ancient Greece by Ubisoft") appear in GOG Galaxy, but it looks like according to the wiki I should report that to GOG?

@Bobcat90 I'm sorry for late response

Looks like For Honor is returned from https://club.ubisoft.com/games

A secondary issue is that neither Discovery Tour games ("Discovery Tour by Assassin's Creed: Ancient Egypt" & "Discovery Tour Ancient Greece by Ubisoft") appear in GOG Galaxy, but it looks like according to the wiki I should report that to GOG?

As far as I know GOG is quite strict about what is game and what is not. Those looks like not really "games" but some kind of educational content. But if you think it should be displayed in GOG Galaxy then yes - report as was described on wiki

Is it necessary to detect games from Ubisoft Club? From what I can tell it doesn't show all games owned (I have 4 other games that don't appear there: Assassin's Creed IV Black Flag, Fallout 3 GOTY, Discovery Tour Ancient Egypt & Discovery Tour Ancient Greece), and it seems to be related more to earning Uplay client rewards/coins through game activity. In my actual Uplay library For Honor isn't there, so that seems like a more accurate reflection of owned games.

@Bobcat90 Right now we don't have a one sure way of retrieving the owned games for a user and using ubisoft club is not the perfect solution but we don't have anything better available to us. (We don't have access to the same data that uplay client does)

Right, Uplay is good source if information. But we wanted to keep support for people that do not have Uplay installed locally.

It looks reasonable to skip getting games from club if local client is already installed though. The problem may arise if Uplay ownership file is outdated. Club games are fetched live so always actual, ownership may be not - for example when you buy game from Ubisoft via browser without opened Uplay.