FriendsOfOuro/geteventstore-php-core

Dependencies

Opened this issue · 7 comments

Akii commented

nicolopignatelli/valueobjects has some requirements that just don't really make any sense like mathiasverraes/money (which is afaik, an example implementation for VOs).

Additionally the Enum thing is not supported by PHPStorm. I'd like deprecate that for simple constants. With that we would only have a dependency to guzzle. Then use rhumsaa/uuid directly for UUID generation.

Not saying that the valueobjects package is bad btw! Just a lot of unnecessary dependencies :)
If you guys agree I'd provide a PR soonish.

@nicolopignatelli if you agree we might just copy as few classes as possible from valueobjects to this project moving to the right namespaces

that, or just code the minimum needed to accomplish whatever we want here

Akii commented

thanks for looking into this :)

did a couple of spike, but it's not that easy to do keeping the bar green, I will give another try next weekend

sorry for postponing again

done with dependency removal, php-enum stuff still to address, but I don't have time 😢 and I'll give priority to #23

Akii commented

Cool! thanks for your work :D #23 sounds nasty