FriendsOfShopware/FroshProductCompare

SCSS 404

Closed this issue · 9 comments

hallo, beim kompilieren des scss bekommen wir zwei 404.
Diese Dateien werden in dem Plugin inkludiert.
@import 'scss/layout/_scroll-up';
@import "scss/variables";

Bildschirmfoto 2020-11-13 um 16 52 23

Hi @komma-d
Not sure why I'm not getting the error on my end, but as I checked the import in scss files, there're syntax error so I'll fixed it and released in the next version.
Thanks for reporting :).

@komma-d I fixed the issue, would you mind to check it on the latest version?

thanks!
I have done the update and saw the fix but its still throwing a 404 for both. Any Idea?
Bildschirmfoto 2020-11-13 um 19 31 16

@komma-d 🤷🏼 can you give me your reproduce steps? Or did you try to rebuild the asset files/ clear cache/etc? if the issue's still not fixed you can contact me via skype in my github profile.

the shop ist running on 6.3.2.1, prod Mode (theme:compile and cache:clear)
is it necassary to include this files? they are already included in the default theme
Bildschirmfoto 2020-11-16 um 11 34 22
Bildschirmfoto 2020-11-16 um 11 34 29

@komma-d hi there, i'm not sure why these files are necessary before, seems like there're some change in the platform :D But now I removed it and the plugin still works fine. Would you mind to check the latest tag again? Thank you :)

sure, is there a update?

sure, is there a update?

@komma-d I just removed the import scss files, hope it works for you 🤔

perfect, thx