Update the StreamDeckLib nuget with latest modifications
Maskime opened this issue · 1 comments
Describe the bug
The didReceiveGlobalSettings
never propagated to actions.
To Reproduce
Steps to reproduce the behavior:
- Create a property_inspector that sends a
setGlobalSettings
instead of asetSettings
- Create an
override
of theOnDidReceiveGlobalSettings
method - Add some logs
- Logs never show
Expected behavior
When overriding the method on an action, it should be called by the ConnectionManager
Error Details
N/A
Screenshots
N/A
Desktop (please complete the following information):
- OS: Windows 10
Additional context
I was able to pinpoint the issue to this :
https://github.com/FritzAndFriends/StreamDeckToolkit/blob/dev/src/StreamDeckLib/ConnectionManager.cs#L186
In the lastest version of the code, this calls the BroadcastMessage()
method, which should work. But in the code of the StreamDeckLib nuget (v0.4.480), it goes to:
if (string.IsNullOrWhiteSpace(msg.context) && string.IsNullOrWhiteSpace(msg.action))
{
ConnectionManager._Logger.LogInformation("System event received: $" + msg.Event);
continue;
}
Which make the ConnectionManager discard the call basically.
My guess then it's just that the StreamDeckLib code is out of sync with the nuget.
I have a few fixes like this to put together and deploy, including updates to the .NET version of the templates and library. I'll take a shot at this over the weekend