FruitieX/teleirc

--upgrade-config is faulty migrating sendTopic and sendNonMsg to relayIRCEvents

petebp opened this issue · 0 comments

With v0.4.8 the sendTopic and sendNonMsg config options were migrated to relayIRCEvents, which allows you to select the forwarded messages more accurate.

But for now config.sendTopic and config.sendNonMsg are only renamed to config.relayIRCEvents. That will result in ambiguous configurations, since there will be two lines for config.relayIrcEvents, which probably set to true and false, if sensNonMsg and sendTopic had different values before. Also, the documentation in the config file is not explaining what's the effect of setting relayIRCEvents to true or false.

The better solution would to fill the array for relayIRCEvents 'topic' if sendtopic were set to true, and at least 'join', 'part', 'quit' if sendNonMsg were set to true in the old config. The should also be a proper decision found for the other allowed options of relayIRCEvents.