FuPeiJiang/ahk_parser.js

Incorrect "ByRef" translation

Opened this issue · 2 comments

jNizM commented

GetRow(RowIndex, ByRef Row) ; old
GetRow(RowIndex, ByRef Row) ; new (incorrect)
GetRow(RowIndex, &Row) ; should be this

v2 Error: Missing comma

See: https://lexikos.github.io/v2/docs/Functions.htm#ByRef

ByRef can easily be changed to & in the function definition,
but now, CALLING the function now requires &


so I need to parse the function definition, find out which params are & and add & to ALL the function calls..
and what if the function definitions are inside #include ?

well, rip the web version of the converter, it would be impossible to look into #include

jNizM commented

Would say just ignore #include files atm. Translate just the pasted code for now.