Remove dependencies on `@fuel-ts/fuel-core`
Closed this issue · 7 comments
As part of FuelLabs/fuels-ts#2143. We have internalised @fuel-ts/fuel-core, therefore they won't be available via NPM once we release.
- Remove the dependency on
@fuel-ts/fuel-core. - Ensure the developer workflow works as expected (build, test, CI).
Note: this PR has not yet been merged and this is a pre-emptive measure to ensure we're not a blocker.
Currently the following two files have dependency on @fuel-ts/account/test-utils which has a dependency on @fuel-ts/fuel-core:
packages/burner-wallet-connector/src/tests/burnerWalletConnector.test.tspackages/evm-connector/src/test/walletConnector.test.ts
These tests will need to run in the CI, so therefore, I am proposing we install fuelup and fuel-core in the pipeline. It would be good to get confirmation from @FuelLabs/frontend before making these changes, so have set at blocked for now.
@petertonysmith94 did you guys also moved to the pipeline in the SDK to handle cases like this?
and regarding running locally, what are the needed changes?
did you guys also moved to the pipeline in the SDK to handle cases like this?
We have not, we've kept the binaries internally (see @internal/fuel-core), so we use these for our CI actions. However, it looks like we could use following action FuelLabs/action-fuel-toolchain
to install the dependencies required for the CI.
regarding running locally, what are the needed changes?
With regards to running locally, it would involve using fuelup and managing the version of forc and fuel-core. Potentially a script to sync these with the current fuels version might be helpful?
@helciofranco I've performed the upgrade to fuels@0.89.0 (which removes the forc and fuel-core dependencies).
Related PR: #89
I have unassigned myself for now and closed the PR:
Please let me know when you come round to the upgrade and I'll more than willing to assist.
I just checked your pr and it's looking good @petertonysmith94 thanks for helping, we're upgrading sdk version as of now
@LuizAsFight you're most welcome, I'm around if you need any assistance upgrading the SDK.
(I'm sure you've got it though 🚀 )