Use `max_fee` policy to charge user

Question

Use `max_fee` policy to charge user

MitchTurner opened this issue 10 months ago · 4 comments

MitchTurner commented 10 months ago

Answer 1 · 2024-02-08T20:37:59.000Z

This was on the Miro board, but I'm not sure what it means :P

Answer 2 · 2024-02-12T12:22:51.000Z

The current codebase converts max_gas into max_fee and deducts this amount from available balances.

It was okay to do because gas_price was statically defined by the transaction itself. But in a new module, since the base gas price is dynamic, the max_fee based on the max_gas is dynamic too. Instead of using this dynamic value, we need to use max_fee defined by the user in the policies if it is available.

Answer 3 · 2024-02-22T20:31:34.000Z

Are we keeping script_gas_limit? I'm still confused about the relationship between gas limit and max_fee.

Answer 4 · 2024-02-22T20:59:52.000Z

yes we need to keep script_gas_limit as a way for users to budget how much of their fee goes into script execution vs witness data etc