FunkFrog/ShareSuite

Item Descriptions Not Appearing On Pick-Up

Closed this issue · 3 comments

ForteZXA commented

Installed Mods
BepInExPack V5.4.1902
HookGenPatcher V1.2.3
R2API V4.0.11
ShareSuite V2.6.0

Describe the bug
In single-player, item descriptions do not appear at the bottom of the screen when you pick them up like usual. I haven't had the chance to test it out in multiplayer yet.

To Reproduce
Steps to reproduce the behavior:

  1. Start a single-player run.
  2. Pick up an item.
  3. Item description doesn't appear at the bottom of the UI.

Expected behavior
Item descriptions should appear at the bottom of the UI as is the case with vanilla.

Additional context
Attached to this report is the log file. I started a run with Loader, killed some enemies to get enough money, opened some chests (normal and large), got items from a shrine of chance, and printed items (did all of this to provide multiple examples in the log file)
LogOutput.log

FunkFrog commented

In theory, all we need to change to make this function properly would be to make sure every client calls the code in the red box, and the line below it (that actually displays the normal pickup message) is removed. I'm not sure how we would make this function with vanilla clients without having their games display double messages.

Either we replace our server-side rich pickup messages with the same system run in this method, replacing the removed line, or find a way to send a networkmessage directly to clients we can confirm have ShareSuite installed, and then have their client run the code we need.

Regardless, this is a quite involved process. I'm going to remove this from the 2.7.0 update and recommend anyone who absolutely needs the pickupmessages disable the rich messages for now (or just hold tab and mouse over the item in your inventory.)

image

FunkFrog commented

Also, the reason this doesn't work anymore is that the way the networkmessages are handled for item pickups changed (entirely client-sided now)

irisfofs commented

This is marked as fixed, but I'm encountering the exact same bug with a fresh install in 1.2.4.1. Works fine in multiplayer, but no pickup messages in singleplayer.