FusionAuth/fusionauth-jwt

JDK 9+ support

skjolber opened this issue · 10 comments

Please add a module descriptor.

Can you provide some additional detail to what you're looking for and the use case? Thanks!

Well an Automatic module name would be a good first step, then later a real module info (guess using moditect-maven-plugin is the fastest). Use-case: Java 11 application with modules.

Will this help you out? See commit 82033d0

I haven't dealt much yet with modules, so please share any feedback you have.

See #10 for a suggestion.

I removed the module-info.java file for now, JDK8 won't compile this, so I'll have to build two artifacts from this project one for Java8, and another for Java9 and only include this when compiling Java9.

To stay on 8, use the moditect plugin:

<plugin>
    <groupId>org.moditect</groupId>
    <artifactId>moditect-maven-plugin</artifactId>
    <version>1.0.0.Beta2</version>
    <executions>
        <execution>
            <id>add-module-infos</id>
            <phase>package</phase>
            <goals>
                <goal>add-module-info</goal>
            </goals>
            <configuration>
                <jvmVersion>${java.module.version}</jvmVersion>
                <overwriteExistingFiles>true</overwriteExistingFiles>
                <module>
                    <moduleInfoFile>src/main/moditech/module-info.java</moduleInfoFile>
                </module>
            </configuration>
        </execution>
    </executions>
</plugin>

with the module-info in a seperate source folder.

Thanks @skjolber for the help! Added it back under commit 3a45068

@robotdan and remember to import jackson modules (read: your module uses the jackson module).

Thanks @skjolber sorry - totally forgot / missed your PR with all of this in it already. Thanks for the help!

I'm obviously Java9 stupid. :-(