FyiurAmron/sortablejs

Unable to modify column 10 onwards

calingasankj opened this issue · 6 comments

calingasankj commented

I wanted to remove sorting on columns 10-13

exmaple:
<sortable 9=nosort 10=nosort 11=nosort>

but it only stops at column 9

FyiurAmron commented

@calingasankj I can confirm, 👀 at it.

FyiurAmron commented

caused by a faulty regex in makeSortableDiv; was
var patt1 = /\bcol_\d_[a-z]+/gi;
while it should be
var patt1 = /\bcol_\d+_[a-z]+/gi;

I will fix it and release shortly.

My test case:

test case:

<sortable 9=nosort 10=nosort 11=nosort>
^Col1^Col2^Col3^Col4^Col5^Col6^Col7^Col8^Col9^Col10^Col11^Col12^
|1,1|one|25/12/2008|1,1|one|25/12/2008|1,1|one|25/12/2008|1,1|one|25/12/2008|
|2,1|two|10/12/2008|2,1|two|10/12/2008|2,1|two|10/12/2008|2,1|two|10/12/2008|
|3a|three|15/12/2009|3a|three|15/12/2009|3a|three|15/12/2009|3a|three|15/12/2009|
|3b|three|:::|3b|three|:::|3b|three|:::|3b|three|:::|
</sortable>
calingasankj commented

Thank you!! 😁😁 you found and fixedthe bug pretty quickly that's awesome 💯👏

  • 🎉1
FyiurAmron commented

@calingasankj I've released a new version 2022-10-25 with this fixed, I'd be very grateful if you could update the plugin in your DW installation and check if the behaviour is now OK on your end.

FyiurAmron commented

@calingasankj bump can you verify it's working OK for you and, if so, close the issue? Thanks in advance.

calingasankj commented

Sorry! I haven't been able to work on it for a while but I did try it out recently after updating and it's working great! Thank you

  • 👍1