Window titles cover application icons
pesader opened this issue · 4 comments
Hi there!
First of all, thanks for developing this extension! I've been using it daily ever since you announced it on r/gnome.
I've noticed the window titles cover the icons when "Move titles into windows" is toggled on. Since I find the icons very important to tell windows apart at glance, I think it could be interesting to move the titles further up. Like so:
ofp_window_captions.trimmed.mp4
I can make a PR with this (very small) change if you like it :)
Hi, thanks for the feedback. The weak point in my title position calculation is the estimated label height, which should work for the default theme and font size on Ubuntu and Fedora. The actual height of the label is not available at that time, so the fix must move the calculation after the label is allocated and read the allocated height.
I made the recording above after changing the source code of the installed extension (in ~/.local/share/gnome-shell/extensions). All I did was changing the number that multiplied WindowPreview.ICON_SIZE.
However, I cloned the repo and it looks like this part of the code has been changed.
I'll try to figure out how to do the same thing in the new version of the code, then submit a PR for review :)
Just installed the extension from the repo and it seems this is already fixed! Version 2.0 is looking great, by the way.
I saw that someone has forked the repository and thought it was you, so I expected that you have the latest version installed. The change has been made to include the actual size of an app icon, which can be resized, not due to label misalignment.
The current repository version is not ready for release yet, but should be usable. Feel free to report bugs.