Explore countries: truncate dataset reference if larger than 2 lines

Question

Explore countries: truncate dataset reference if larger than 2 lines

Closed this issue 6 years ago · 7 comments

pzwsk commented 6 years ago

Truncate dataset reference (title, publisher, date) to 2 lines max with [...] at the end if longer
Ensure same height size for all rows

See issue below

Answer 1 · 2018-12-18T13:44:56.000Z

Hi @CIMAManuel could you have a look at this one?

Thanks!

Answer 2 · 2018-12-21T08:52:34.000Z

As per @oncletom in #377, this is only working on Chrome.

I putting back issue to In Progress.

Answer 3 · 2018-12-21T09:30:43.000Z

Are you like this?! ... It's not easy because the block of subtitle_datasetlist is composed by 3 object (title + institution + modify_time) and every object may be short or longer and all may exceed 2 lines. Sure I'm try to fix just use visual html & css capabilities... Another way will be to use JS to count words or charachters...
Well this is the fix now

Firefox preview:

chrome preview:

Answer 4 · 2018-12-21T15:22:25.000Z

I understand. Is there no possibility to treat it as one object? Also, in examples above, the three dots are always there. That should not be the case.

…

On Fri, Dec 21, 2018 at 10:30 AM dedandy ***@***.***> wrote: Are you like this?! ... It's not easy because the block of *subtitle_datasetlist* is composed by 3 object (title + institution + modify_time) and every object may be short or longer and all may exceed 2 lines. Sure I'm try to fix just use visual html & css capabilities... Another way will be to use JS to count words or charachters... Well this is the fix now Firefox preview: [image: opendri_index_-datasets_list-2018-12-21_10 18 55 png-_2018-12-21_10 19 28] <https://user-images.githubusercontent.com/2742862/50334917-07316400-050a-11e9-80b8-3659b3e195cb.png> chrome preview: [image: 5084874806132736] <https://user-images.githubusercontent.com/2742862/50335097-8f176e00-050a-11e9-9439-80f73def9405.png> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#371 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACRKx-mVHjr1JWerRCRCdsF6piVIiP-Cks5u7KpEgaJpZM4ZYU8G> .

Answer 5 · 2019-01-11T09:53:17.000Z

We pushed in the branch named "#371_trunk_over2lines" the last version of this issue.
There are some problems with Firefox yet, but we can't do better.
If you have any ideas (@pzwsk , @oncletom ).

Answer 6 · 2019-01-17T13:35:07.000Z

Hi @CIMAManuel @dedandy still need to merge your fix in dev, right?

Answer 7 · 2019-01-31T09:09:22.000Z

I'm happy to have a look at it.