GIScience/openrouteservice-app-legacy

Doesn't work if you don't share your location

Closed this issue · 23 comments

Hello,

OpenRouteService doesn't work on Firefox. I can't set up a route (eg. Bordeaux - Paris {France}). I just have this error :

Sorry, no route was found between the selected points. Please choose your points closer to a road (that is traversable based your route preferences).

The "options" and "site preferences" have trouble too (some things are missing like in the dropdown list, etc...). I tried with Chrome and that worked well.

I'm on Fedora 24 with Firefox 47. I use these add-on that I disabled to test :

  • uBlock Origin
  • Privacy Badger
  • Https Everywhere
  • Greasemonkey
  • Decentraleyes

I also use this user.js file but I didn't tried without since I don't think that can interfere :

# PERFORMANCE
user_pref("layers.acceleration.force-enabled", true);
user_pref("layers.offmainthreadcomposition.enabled", true);
user_pref("layers.offmainthreadcomposition.async-animations", true);
user_pref("layers.async-video.enabled", true);
user_pref("layout.frame_rate.precise", true);
user_pref("webgl.force-enabled", true);
user_pref("webgl.msaa-force", true);
user_pref("html5.offmainthread", true);

# PRIVACY
user_pref("browser.pocket.enabled", false);
user_pref("privacy.trackingprotection.enabled", true);
user_pref("geo.enabled", false);
user_pref("browser.safebrowsing.enabled", false);
user_pref("browser.safebrowsing.malware.enabled", false);
user_pref("dom.event.clipboardevents.enabled", false);
user_pref("browser.send_pings", false);
user_pref("dom.battery.enabled", false);

# USABILITY
user_pref("browser.tabs.loadBookmarksInBackground", true);

I hope that can be fixed or have help if the problem come from my setup. Thanks !

Hello, are you still having route computation difficulties?

Yes and I just found the culprit. As you can see in my previous message, I use "geo.enabled false". When this setting is disabled (false) it break the service!

With "geo.enabled false" the menus "options" and "site preferences" works, I can set a route with right click "Set as starting point" / "Set as destination" but i can't set a route by writing starting point and destination in text fields. Maybe there is an other Firefox setting that the service don't like.

What is in "strikethrough" was a cache problem. If I set "geo.enabled" to true everything works !

Just to be clear, obviously Openrouteservice should work without "geo.enabled".

Sorry, we don't have the capacities to implement these functionalities.

Wow I'm so disappointed ! Maybe you didn't understand what I meant ? Openrouteservice should just work without "geo.enabled" that is only a feature to automatically locate you. To set a route between 2 cities Openrouteservice don't have to know where I'm now. It shouldn't be that hard to let the service work even if it don't know where I'm at this moment.

I tested to re-enable "geo.enabled" and simply refuse to share my location when Firefox asked and Openrouteservice worked well. I think there is just a little bug that break Openrouteservice when it can't use the geolocation service of the browser.

Ok, perfect, thanks!

Thanks to reopen it. I think to reproduce the problem you have to disable "geo.enabled" (type about:config in Firefox address bar, search geo.enabled, set it to false) and the most important clear the cache before trying.

Feel free to fix this via a fork and pull request, the repository is public.

If I knew how to fix it you would already have a PR ;)
Unfortunately I'm not a developer but I try to help the best I can do.

Any news ?

Hi, I'm on FF 48.0.2. I cannot reproduce your error. E.g. disabling geo.enabled and routing from Berlin to Hamburg works fine. Could you give a more precise description of how you encounter that error?

It's maybe due to the cache that it work even when disabling geo.enabled. Can you try to make "Ctrl+H", right click on Openrouteservice, click on "forget this site" please and retry ?

It should not be difficult to fix this problem. "geo.enabled" set to false mean that openrouteservice can't retrieve the location of the user. This surprisingly break openrouteservice. When openrouteservice can't retrieve the location of the user using a fallback default location should be enough to don't break everything.

I found that even if I enable "geo.enabled" openrouteservice can break. In Firefox with "geo.enabled" set to "true" when you go to openrouteservice Firefox will ask you to share your location. If you refuse openrouteservice breaks.

Openrouteservice should just work even without retrieving / knowing your location.

It should not be difficult to fix this problem. I hope that will be done.
Thanks !

Hi Paviluf, I think I found the problem. Working on it.

Thank you very much !
I don't know if it should work now or if there is a delay to update the site but for now that doesn't work.

The Client still needs to be updated. Let me know if you still experience the issue on the debug version here: http://openls.geog.uni-heidelberg.de/openrouteservice-3.0/

The problem is still here. If I don't share my location nothing works but if I share it everything works.

I hope you can look again at it.