GRTLCollaboration/GRChombo

Automatically make data directory

the-florist opened this issue · 1 comments

Currently the hdf5 and pout directories are created automatically, but the data branch is only created for specific versions of GRChombo (e.g. in PunctureTracker). All of these path directories are listed in params.txt, so all could be created automatically in the code. Currently the "data" directory is created, for instance in SurfaceExtraction.impl.hpp (lines 30-38), with a block like this:

if (!FilesystemTools::directory_exists(m_params.data_path)) FilesystemTools::mkdir_recursive(m_params.data_path);

Perhaps we can move this into the GRChombo core files (e.g. in ChomboParameters.hpp, near where the HDF5 and pout directories are created)?

--Ericka

Made a PR to fix this, number 254.