GSA/data.gov

Merge MDTranslator work in datagov branch to main

Closed this issue · 4 comments

btylerburton commented

User Story

In order to park our spec-compliant work, datagov team wants to merge the datagov branch into main for MDTRanslator. This will allow us to begin work on the sibling reader which will need changes to accomodate the divergent XML markup in catalog documents.

Depends upon: #4862

Background

[Any helpful contextual notes or links to artifacts/evidence, if needed]

Security Considerations (required)

[Any security concerns that might be implicated in the change. "None" is OK, just be explicit here!]

Sketch

  • Merge gsa/MDTranslator datagov branch into main
  • Copy reader work into sibling namespace
    • lib/adiwg/mdtranslator/readers/iso19115_2 -> lib/adiwg/mdtranslator/readers/iso19115_2_datagov
    • test/readers/iso19115_2 -> test/readers/iso19115_2_datagov
    • test/translator/tc_iso19115_2_to_dcatus.rb -> test/translator/tc_iso19115_2_datagov__to_dcatus.rb
  • Add new namespaced tests to Rakefile
Bagesary commented

This ticket is the pre-requisite for #4924

rshewitt commented

master now has spec-compliant ( feature-incomplete ) iso19115-2 & -3 readers excluding our dcat-us writer changes. edits to that writer will come later.

rshewitt commented

@btylerburton related to our conversation yesterday. keyword is required in dcatus but optional in -2 ( at least where we're currently reading it from ). here's the element

<xs:element name="descriptiveKeywords" type="gmd:MD_Keywords_PropertyType" minOccurs="0" maxOccurs="unbounded"/>

this puts us in an interesting situation where we have to explain why something was rejected based on the destination schema and not the input source.

  • 😕1
btylerburton commented

Thanks for doing this work @rshewitt. It will be crucial to our designing the requirements for what should pass validation or not.

  • 👍1