Implement a banner in gs-connect if OpenSSL or any similar dependency is not detected or encounters an issue
cu8code opened this issue · 3 comments
Describe your request
If OpenSSL is not installed, Gs-connect triggers a notification indicating that OpenSSL is not found. Initially, I overlooked this notification, which led to wasting 30 minutes trying to diagnose the issue.
Proposed solution
A more effective approach would be to implement a banner in Gs Connect that alerts users when such issues occur.
Here their is not indication of error
Something similar like this banner, on top of GS connect if something go wrong
Alternatives
No response
GSConnect version
57
Installed from
Extension Manager
GNOME Shell version
46.2
Linux distribution/release
fedora 40
Additional context
No response
Hmm. That's not the worst idea. And GSConnect already has (and I think still has) banners that show in the Preferences interface, so most of the code is probably already there.
I suspect one reason for choosing a notification is that it doesn't require opening the Preferences application to be seen, whereas a banner would. (An issue with missing dependencies could be encountered when loading the GSConnect Quick Settings tile, which would still trigger a notification without requiring the user to open Preferences.)
For missing openssl
, specifically, it seems like the user would have to be in the Preferences app, because there's no way to pair devices without it. But we've seen cases in the past where an OS upgrade removed OpenSSL from the system, which caused problems with an already-configured GSConnect.
...Still, I suppose we could do both.
..Still, I suppose we could do both.
that would be very nice
For missing openssl, specifically, it seems like the user would have to be in the Preferences app, because there's no way to pair devices without it. But we've seen cases in the past where an OS upgrade removed OpenSSL from the system, which caused problems with an already-configured GSConnect.
I removed openssl from my system for god knows whatever reason.
I could implement this feature if you assign me It would be fun to help.
@cu8code We don't typically assign issues, but pull requests are always welcome and I'll be happy to review, or to provide what information I can regarding the GSConnect internals.
What I can tell you right now is:
- The OpenSSL check is in
src/service/backends/lan.js
, but since that's divorced entirely from the Preferences app, you might be better off just adding a separate check tosrc/preferences/service.js
. - The banner I mentioned is the "Discovery Disabled" infobar, defined in
data/ui/preferences-window.ui
(inside theGtkRevealer
that starts on line 708). But since it has fixed text content, it probably isn't actually of much use in terms of "existing code", other than as a template to follow. - Display of the banner is bound to the
'discoverable'
settings action insrc/preferences/service.js
:gnome-shell-extension-gsconnect/src/preferences/service.js
Lines 203 to 210 in 97a1287