PacketHandler breaks other plugins listening to packets directly
Closed this issue · 3 comments
The current implementation of the PacketHandler breaks other plugins listenting to packets directly.
An example is my plugin: https://github.com/SBDPlugins/MapReflectionAPI
There is no need to remove them before, you can directly add your ChannelDuplexHandler using addBefore(). You can find an example here:
https://github.com/SBDPlugins/MapReflectionAPI/blob/master/src/main/java/tech/sbdevelopment/mapreflectionapi/listeners/PacketListener.java#L60
yeah, both methods seem to be present (see)... are you proposing we should delete the pipeline.remove(player) and only leave the addBefore?
yeah, both methods seem to be present (see)... are you proposing we should delete the
pipeline.remove(player)and only leave the addBefore?
Yes, because there is no reason to call the remove, and it breaks other plugins.
Closed by #144