Parallel Block Merge mental breakdown
Closed this issue · 4 comments
Gaming32 commented
Just run Parallel Block Merge Sort yourself and view the carnage.
For reference: https://youtu.be/0ae2q700NNc?t=8249
EmeraldBlock commented
EmeraldBlock commented
Cause identified: Highlights.clearAllMarks()
was not synchronous. I have no clue how that fixes this.
Gaming32 commented
Ah yes, threading without a GIL to keep you safe. always fun
EmeraldBlock commented
clearAllMarks()
is used by binary insertion sort which is used by parallel block merge, so I guess that's how it's relevant
still no clue how this alters the sort's behavior; the Highlights functions only modify Highlights properties
Oh, the issue was just that the exceptions thrown by the Highlights functions killed the sorting threads