Gasman2014/KiCad-Diff

grep dependency causes silent/inaccurate failure on Windows machines

Closed this issue · 10 comments

I downloaded and ran KiCad-Diff for the first time today, and could not get it to produce a diff of any two PCB files - even ones I knew were radically different. Then I noticed this line:

image

Is there some way to remove the grep dependency here that will allow this to run smoothly on Windows 10? Or, perhaps, there's another way to run it that won't butt into this issue?

It may be possible to use FINDSTR in Windows. I will have a look at some point - there may also be a different way to do this altogether. There is a bit of refactoring & development going on at present and this may get shaken out in the process.
I will keep this issue open.

I'm working on putting all post processing of the scm commands in Python and remove reliance on external utilities. This way, the system is easier to run across platforms;

@Cushychicken could you test with the latest version and report?

@jnavila sure! May not be until the weekend.

Thanks for looking into this.

meanwhile @Cushychicken if the grep command is missing you could use Windows PowerShell or the Linux subsystem for windows.

I'm working on putting all post-processing of the same commands in Python and remove reliance on external utilities.

@jnavila this would be nice!

@jnavila did you solve this issue? If yes we could close this. What do you think?

I did it in #34 and following. This can be closed.

Oh, I cannot close it. maybe @Cushychicken or @Gasman2014

Finally got around to testing - life has been insane these last few months

Fixed - closing

@Cushychicken glad to hear that, thanks.