Gear61/Random-Name-Picker

[Accessibility] Change the text size from dp to sp

mohammedhemaid opened this issue · 2 comments

mohammedhemaid commented

@Gear61 I saw this in the "name_choosing_settings" layout and I will check the other layouts to edit it.

Gear61 commented

Hey @mohammedhemaid, thanks for filing this issue! There is a reason why I use dp instead of sp; sp is actually a dynamic setting that adjusts with the OS level text size setting. I feel like a lot of people don't know that (even people who work at top tech companies) and just blindly follow what the IDE tells them; using sp is actually a significant undertaking that involves auditing across all text size settings. To make things even more complicated, we use a TextView variant for icons, so it would be weird if all the icons started changing based on text size. With all that being said, are you sure you want to work on this? We would need to go through surface by surface and make sure all the text size settings worked.

  • 👍1
mohammedhemaid commented

@Gear61 Actually I didn't know about that, I can change all the surfaces but I will keep it like this. and I will change the group dialog settings to meet the flow. Thanks for the feedback!